[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:56
+  /// operations.
+  class ValueModel {
   public:
----------------
I really like this new name/API. Much clearer concept.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:64
+    ///
+    ///  `Val1` must be assigned to a storage location of type `Type`.
+    ///
----------------
What does this comment mean, now that there's no environment? Could we say something specific to the values themselves?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118596/new/

https://reviews.llvm.org/D118596