[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added inline comments.


================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:75
+static cl::opt<std::string>
+    BitcodeLibrary("target-library",
+                   cl::desc("Path for the target bitcode library"),
----------------
tianshilei1992 wrote:
> `target-library` is not the common name we call it. Maybe `device-runtime-library`?
I think I called it `bitcode-library` later, since technically it's just any bitcode file that's linked in along LTO.


================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:986
+  if (!BitcodeLibrary.empty()) {
+    // FIXME: Hacky workaround to avoid a backend crash at O0.
+    if (OptLevel[1] - '0' == 0)
----------------
tianshilei1992 wrote:
> Is this still needed now?
It still breaks, but I removed it later. My ordering for these patches is a bit of a mess, sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117048/new/

https://reviews.llvm.org/D117048