[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

Shilei Tian via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 31 10:47:03 PST 2022


tianshilei1992 added a comment.

In D116637#3284773 <https://reviews.llvm.org/D116637#3284773>, @ABataev wrote:

> sema and parsing tests?

Tests will be in the patch for code gen.



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:10921
+/// Get the node id of the fixed point of an expression \a S.
+llvm::FoldingSetNodeID getNodeId(ASTContext &Context, const Expr *S) {
+  llvm::FoldingSetNodeID Id;
----------------
ABataev wrote:
> static
Sure, but I usually prefer not to use `static` for a function in an anonymous name space.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116637/new/

https://reviews.llvm.org/D116637



More information about the cfe-commits mailing list