[PATCH] D116675: [OpenMP] Search for static libraries in offload linker tool

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 31 10:01:26 PST 2022


jhuber6 added inline comments.


================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:646
+    if (Arg.startswith("-L"))
+      LibraryPaths.push_back(Arg.drop_front(2));
+
----------------
jdoerfert wrote:
> This seems to handle `-Lfoo`, what about `-L bar`? at least a todo would be good.
These arguments come from clang, and are somewhat normalized by clang so they will always be in the form `"-Lfoo"` when they come from clang. I could add some checks for that if we expect the user to be calling this manually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116675/new/

https://reviews.llvm.org/D116675



More information about the cfe-commits mailing list