[PATCH] D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 31 09:04:02 PST 2022
Anastasia added inline comments.
================
Comment at: clang/include/clang/Basic/Builtins.def:88
// '__builtin_' prefix. It will be implemented in compiler-rt or libgcc.
+// G -> this function uses generic address space (OpenCL).
+// P -> this function uses pipes (OpenCL).
----------------
It might be better to avoid adding such limited language-specific functionality into generic representation of Builtins. Do you think could we could just introduce specific language modes, say:
`OCLC_PIPES`
`OCLC_DSE`
`OCLC_GAS`
and then check against those in `builtinIsSupported`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118605/new/
https://reviews.llvm.org/D118605
More information about the cfe-commits
mailing list