[PATCH] D118609: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 31 07:43:43 PST 2022


RKSimon created this revision.
RKSimon added reviewers: rnk, aaron.ballman, zturner, jhenderson.
Herald added a subscriber: dexonsmith.
RKSimon requested review of this revision.
Herald added projects: clang, LLVM.
Herald added a subscriber: cfe-commits.

Now that VS2017 support has been dropped (D114639 <https://reviews.llvm.org/D114639>), the LLVM_HAS_RVALUE_REFERENCE_THIS define is always true and the LLVM_LVALUE_FUNCTION define is always enabled for ref-qualifiers.

This patch proposes we remove the defines and use the qualifiers directly.

NOTE: I'm not intending to push this before the 14.x branch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118609

Files:
  clang/include/clang/ASTMatchers/ASTMatchersInternal.h
  clang/include/clang/Basic/DirectoryEntry.h
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h
  llvm/include/llvm/ADT/Optional.h
  llvm/include/llvm/ADT/PointerIntPair.h
  llvm/include/llvm/Support/Compiler.h
  llvm/unittests/ADT/OptionalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118609.404525.patch
Type: text/x-patch
Size: 12879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220131/a06c88ba/attachment.bin>


More information about the cfe-commits mailing list