[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 31 06:25:24 PST 2022


sammccall added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:2387
     // unit.
     LangOpts.LineComment = true;
   }
----------------
It's much less obvious what this does in raw lexing mode.

My rough understanding is raw lexing mode is ~stateless and we may choose to recreate the lexer, start lexing at any point etc. So having a stateful flag flip won't actually result in the same text being lexed the same way, because we may not run in the same sequence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118471/new/

https://reviews.llvm.org/D118471



More information about the cfe-commits mailing list