[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

Mon Jan 31 02:11:38 PST 2022

ro added a comment.

In D91607#3280808 <https://reviews.llvm.org/D91607#3280808>, @efriedma wrote:

> Testcase?

I thought the 3 testcases adjusted in D91608 <https://reviews.llvm.org/D91608> to use `__builtin_extract_return_addr` and fixed by this patch were enough.  Otherwise, should I just augment `clang/test/CodeGen/builtins-sparc.c` or better create a new test?

> Do you need to ptrtoint/inttoptr?  I would expect that the address is an `i8*`, so you can just GEP an appropriate number of bytes.

TBH, I know practically nothing about LLVM codegen, so I rely heavily on guidance.  IIRC this patch was developed by searching for similar code in `TargetInfo.cpp` and modifying it until it did what I needed.  Is this the place to read on GEP <https://llvm.org/docs/GetElementPtr.html>?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91607/new/

https://reviews.llvm.org/D91607