[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 29 22:38:56 PST 2022


Quuxplusone updated this revision to Diff 404341.
Quuxplusone added a comment.

It seems like we need `tryToRecoverWithCall` to always identify a diagnostic explaining the problem, so just short-circuit-returning `ExprError()` with no diagnostic is not acceptable. Let's try this version instead.
(This is also now based on top of D118552 <https://reviews.llvm.org/D118552>.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117603/new/

https://reviews.llvm.org/D117603

Files:
  clang/lib/Sema/Sema.cpp
  clang/lib/Sema/SemaExprMember.cpp
  clang/test/SemaCXX/PR52970.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117603.404341.patch
Type: text/x-patch
Size: 5044 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220130/05cd0767/attachment-0001.bin>


More information about the cfe-commits mailing list