[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 29 06:16:00 PST 2022


zahiraam added a comment.

In D114483#3280905 <https://reviews.llvm.org/D114483#3280905>, @MaskRay wrote:

> Closed by 8ba9c794feb30cd969b9776c39873def10c51bff <https://reviews.llvm.org/rG8ba9c794feb30cd969b9776c39873def10c51bff>.
>
> If the commit message contained `Differential Revision:`, the differential would be closely automatically when you pushed it to the git repo.
> Please ensure the tag is contained next time. `arc diff` adds this tag automatically.
>
> `clang/include/clang/Basic/AttrDocs.td` had some formatting issues and caused (`-DLLVM_ENABLE_SPHINX=ON`) `ninja docs-clang-html` to fail.
> I fixed it. Please test this build target for `.rst` and `AttrDocs.td` changes.

@MaskRay OK thanks. I see other clang-format issues. Should those be fixed too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114483/new/

https://reviews.llvm.org/D114483



More information about the cfe-commits mailing list