[PATCH] D117137: [Driver] Add CUDA support for --offload param
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 28 08:23:28 PST 2022
yaxunl added a comment.
In D117137#3274035 <https://reviews.llvm.org/D117137#3274035>, @dcastagna wrote:
> @yaxunl Are you OK landing this change as it is, without the check for OS and environment in getHIPOffloadTargetTriple?
> We can follow up with patch that adds checks for in OS and environment in Triple.cpp. Is that what you meant?
LGTM. @tra @linjamaki What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117137/new/
https://reviews.llvm.org/D117137
More information about the cfe-commits
mailing list