[clang] 9939bb6 - [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

David Tenty via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 28 08:19:10 PST 2022


Author: David Tenty
Date: 2022-01-28T11:18:55-05:00
New Revision: 9939bb6682128235c9f0f6076d15ae5191d2dd05

URL: https://github.com/llvm/llvm-project/commit/9939bb6682128235c9f0f6076d15ae5191d2dd05
DIFF: https://github.com/llvm/llvm-project/commit/9939bb6682128235c9f0f6076d15ae5191d2dd05.diff

LOG: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test

We can pass this test now thanks to recent changes that allow us to use PGO without LTO, so un-XFAIL the test and update the comments.

Differential Revision: https://reviews.llvm.org/D118474

Added: 
    

Modified: 
    clang/test/Profile/gcc-flag-compatibility-aix.c
    clang/test/Profile/gcc-flag-compatibility.c

Removed: 
    


################################################################################
diff  --git a/clang/test/Profile/gcc-flag-compatibility-aix.c b/clang/test/Profile/gcc-flag-compatibility-aix.c
index ead654dd102fb..db12e05c247b5 100644
--- a/clang/test/Profile/gcc-flag-compatibility-aix.c
+++ b/clang/test/Profile/gcc-flag-compatibility-aix.c
@@ -7,7 +7,8 @@
 // -fprofile-use=<dir>        Uses the profile file <dir>/default.profdata
 // -fprofile-use=<dir>/file   Uses the profile file <dir>/file
 
-// On AIX, -flto is required with -fprofile-generate
+// On AIX, -flto used to be required with -fprofile-generate, so test those
+// extra cases.
 
 // RUN: %clang %s -c -S -o - -emit-llvm -target powerpc64-unknown-aix -flto -fprofile-generate | FileCheck -check-prefix=PROFILE-GEN %s
 // PROFILE-GEN: @__profc_main = {{(private|internal)}} global [2 x i64] zeroinitializer, section

diff  --git a/clang/test/Profile/gcc-flag-compatibility.c b/clang/test/Profile/gcc-flag-compatibility.c
index cdec997a7aaa2..9f83117c1ccdf 100644
--- a/clang/test/Profile/gcc-flag-compatibility.c
+++ b/clang/test/Profile/gcc-flag-compatibility.c
@@ -7,8 +7,7 @@
 // -fprofile-use=<dir>        Uses the profile file <dir>/default.profdata
 // -fprofile-use=<dir>/file   Uses the profile file <dir>/file
 
-// On AIX, -flto is required with -fprofile-generate. gcc-flag-compatibility-aix.c is used to do the testing on AIX with -flto
-// XFAIL: aix
+// On AIX, -flto used to be required with -fprofile-generate. gcc-flag-compatibility-aix.c is used to do the testing on AIX with -flto
 // RUN: %clang %s -c -S -o - -emit-llvm -fprofile-generate | FileCheck -check-prefix=PROFILE-GEN %s
 // PROFILE-GEN: @__profc_main = {{(private|internal)}} global [2 x i64] zeroinitializer, section
 // PROFILE-GEN: @__profd_main =


        


More information about the cfe-commits mailing list