[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 28 01:50:58 PST 2022


fhahn added inline comments.


================
Comment at: clang/test/CodeGen/builtins-elementwise-math.c:117
+  // CHECK-NEXT: call <4 x i32> @llvm.usub.sat.v4i32(<4 x i32> [[VU1]], <4 x i32> [[VU2]])
+  vu1 = __builtin_elementwise_sub_sat(vu1, vu2);
+
----------------
It might be good to have tests where one argument is signed and the other unsigned as well. Those appear to be missing for other builtins as well unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117898/new/

https://reviews.llvm.org/D117898



More information about the cfe-commits mailing list