[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.
Ellis Hoag via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 27 13:33:54 PST 2022
ellis added inline comments.
================
Comment at: llvm/include/llvm/ProfileData/InstrProf.h:284-287
+ FE = 0x1, // A frontend clang profile, incompatible with other attrs.
+ IR = 0x2, // An IR-level profile (default when -fprofile-generate is used).
+ BB = 0x4, // A profile with entry basic block instrumentation.
+ CS = 0x8, // A context sensitive IR-level profile.
----------------
Can we expand these names instead of using acronyms? It would help us remember what these flags do by being more descriptive.
Example: `InstrProfKind::BB` => `InstrProfKind::WithFunctionEntry`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115393/new/
https://reviews.llvm.org/D115393
More information about the cfe-commits
mailing list