[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Code refactor (NFC)
Richard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 27 08:57:58 PST 2022
LegalizeAdulthood added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:146
+ if (!HandlerDecl->hasBody()) {
+ checkFunction(HandlerDecl, HandlerExpr);
return;
----------------
Why do we ignore the return value of `checkFunction` here?
Also, the name doesn't reveal to me why the result is true
or false, e.g. it acts like a predicate but its name doesn't ask
a question.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118370/new/
https://reviews.llvm.org/D118370
More information about the cfe-commits
mailing list