[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

Valentin Clement via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 27 06:10:05 PST 2022


clementval added inline comments.


================
Comment at: flang/include/flang/Frontend/CompilerInvocation.h:89
+  /// These values are found in the preprocessor options.
+  void setFortranOpts();
 };
----------------
@awarzynski I was looking at this file recently and I was wondering why we have different case style? Is there a particular reason? 


================
Comment at: flang/include/flang/Frontend/PreprocessorOptions.h:29
+#endif // LLVM_FLANG_PREPROCESSOROPTIONS_H
\ No newline at end of file

----------------
You have a couple of these on your patch. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93401/new/

https://reviews.llvm.org/D93401



More information about the cfe-commits mailing list