[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 26 17:30:49 PST 2022


dblaikie added a comment.

I didn't find any mention of Darwin in RecordLayoutBuilder, which surprised me - I thought maybe Darwin was using the ClangABICompat to express its ABI compatibility requirements (which would sort of be handy rather than having to test multiple target features, for those targets that define their ABI by Clang's behavior - though I guess even those targets might be willing to take some ABI breaks against themselves sometimes (looks like they have, historically - looking at the other ClangABICompat values and where/how they're tested - I don't see target tests against Darwin and PS4 for all of them)) but doesn't look like it.

So - should I be testing Darwin/MacOS/something support differently than I have?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117616/new/

https://reviews.llvm.org/D117616



More information about the cfe-commits mailing list