[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D56303#3273694 <https://reviews.llvm.org/D56303#3273694>, @LegalizeAdulthood wrote:

> In D56303#3272711 <https://reviews.llvm.org/D56303#3272711>, @aaron.ballman wrote:
>
>> The rule of thumb is: if you have significant NFC changes,
>> do them first and push the changes (often doesn't even
>> require a review because it's NFC, but that depends on
>> what comfort level you have about the changes being NFC),
>> and then do the functional changes on top of the improved
>> code.
>
> This is reasonable, but is it written down anywhere so that people
> don't have to through this trial by fire every time? `:)`

Yup, in about the most obtuse place you could image: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. We could probably stand to update https://llvm.org/docs/DeveloperPolicy.html to be more explicit about this and document it in a much more obvious place. (I agree with the complaint about us doing a poor job of writing these kinds of expectations down.)

Oops, forgot to accept the last time I said I thought this looked good. Please still give a day or two before landing in case @JonasToth or @alexfh have further comments or concerns.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56303/new/

https://reviews.llvm.org/D56303