[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

In D117744#3273481 <https://reviews.llvm.org/D117744#3273481>, @MaskRay wrote:

> In D117744#3273463 <https://reviews.llvm.org/D117744#3273463>, @dblaikie wrote:
>
>> I don't especially feel that removing low-cost features like this is a great idea (the benefit to cleaning up a small amount of code compared to the (albeit small) risk of breaking users doesn't seem high value to me), but sure - give it a go.
>
> Thanks:)
>
> This is to ensure that there are no producers: then we can do something more ambitious, like removing assembler support:)
>
> Driver change is a good start because if someone has justifiable complaint, the change can be relatively easily reversed without churn to the underlying implementation.
>
> It will also make future removal of .zdebug from ld.lld justifiable.

Yeah, I appreciate the desire, but it doesn't seem especially burdensome to support (since we'll still have support for the SHF_COMPRESSED style and it's not a lot of code on top of that to support the zdebug style) so I don't see as much value in making these changes, but that's OK.

Oh, one thing: would probably be good to make two separate commits, one for -gz and one for the --compress-debug-sections


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117744/new/

https://reviews.llvm.org/D117744