[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 26 09:55:34 PST 2022


JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

This looks reasonable to me, though I'd prefer we keep the forward declare. The scalar->vector transform is mechanical and the `if (Args.hasArg(options::OPT_fopenmp_new_driver))` cruft will disappear when we return to a single driver implementation.



================
Comment at: clang/include/clang/Driver/Driver.h:45
+class Command;
+class Compilation;
+class JobList;
----------------
This looks like it should be a breaking change - InputInfo is no longer forward declared. Would it be reasonable to keep the forward declaration and put the typedef between class statements and the LTOKind enum?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116541/new/

https://reviews.llvm.org/D116541



More information about the cfe-commits mailing list