[PATCH] D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM, aside from the name that can be fixed on a final commit!



================
Comment at: clang/lib/Headers/opencl-c-base.h:78
+// space overloads for builtin functions that take a pointer argument.
+#define __opencl_c_named_addrsp_builtins 1
+#endif // !defined(__opencl_c_generic_address_space)
----------------
I think for consistency it's better to spell `addrsp` -> `address_space` as we don't gain much space anyway...

Or maybe we could use `__opencl_c_builtins_with_named_address_spaces`?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118158/new/

https://reviews.llvm.org/D118158