[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

[Jesko Appelfeller via Phabricator via cfe-commits]

JesApp updated this revision to Diff 403244.
JesApp added a comment.

As requested by @carlosgalvezp, this update uses the get_tidy_invocation function, rather than building it's own test invocation.

I chose to pass all arguments of the script, in case any of them ever have an impact on what is being printed. The exception is the tmpdir argument, since this directory would get created even if the test invocation then failed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118104/new/

https://reviews.llvm.org/D118104

Files:
  clang-tools-extra/clang-tidy/tool/run-clang-tidy.py


Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
===================================================================
--- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -254,14 +254,12 @@
     build_path = find_compilation_database(db_path)
 
   try:
-    invocation = [args.clang_tidy_binary, '-list-checks']
-    if args.allow_enabling_alpha_checkers:
-      invocation.append('-allow-enabling-analyzer-alpha-checkers')
-    invocation.append('-p=' + build_path)
-    if args.checks:
-      invocation.append('-checks=' + args.checks)
-    if args.config:
-      invocation.append('-config=' + args.config)
+    invocation = get_tidy_invocation("", args.clang_tidy_binary, args.checks,
+                                     None, build_path, args.header_filter,
+                                     args.allow_enabling_alpha_checkers,
+                                     args.extra_arg, args.extra_arg_before,
+                                     args.quiet, args.config, args.line_filter)
+    invocation.append('-list-checks')
     invocation.append('-')
     if args.quiet:
       # Even with -quiet we still want to check if we can call clang-tidy.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118104.403244.patch
Type: text/x-patch
Size: 1232 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220126/a923d6b9/attachment.bin>