[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

Qiu Chaofan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 25 18:16:17 PST 2022


qiucf added a comment.

Thanks for the fix!



================
Comment at: clang/lib/Headers/ppc_wrappers/mm_malloc.h:22
 #else
+#if defined(__linux__)
 extern "C" int posix_memalign (void **, size_t, size_t) throw ();
----------------
Actually I just realised we don't need this guard, Clang already has a hack for this: previous declaration in system header has `throw ()` but later doesn't is okay.

See x86's header https://github.com/llvm/llvm-project/blob/510710d0374908e3e2bd37f9a32065da423a7e4c/clang/lib/Headers/mm_malloc.h#L21-L25 .

I tested on Linux.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117972/new/

https://reviews.llvm.org/D117972



More information about the cfe-commits mailing list