[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

I don't know the AVR specific thing but having this toolchain-specific diagnostic in the toolchain-specific file seems the right direction.



================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:418
+    // a '.s' suffix.
+    for (unsigned I = 0; I < DriverArgs.size(); I++) {
+      StringRef Arg(DriverArgs.getArgString(I));
----------------
https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118095/new/

https://reviews.llvm.org/D118095