[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 25 10:45:23 PST 2022
jansvoboda11 added a comment.
In D114095#3263086 <https://reviews.llvm.org/D114095#3263086>, @vsapsai wrote:
> My understanding was that we were going with ID vectors approach and not with bitvectors, and the current code still uses bitvectors. Also I have a minor readability concern about `auto` usage, it seems to be used more often than the coding standard <https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable> asks for. But that usage is in serialization/deserialization code which I wasn't sure if it was going to stay.
Ah, sorry about that. Fixed in latest revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114095/new/
https://reviews.llvm.org/D114095
More information about the cfe-commits
mailing list