[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM aside from some small nits.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:415
+  let Content = [{
+SYCL defines some special classes (accessor, sampler and stream) which require
+specific handling during the generation of the SPIR entry point.
----------------
I love the Oxford comma and am not afraid to admit it in public. :-D


================
Comment at: clang/include/clang/Basic/AttrDocs.td:422
+``__finalize`` method (the ``__finalize`` method is used only with the
+``stream`` type). Kernel parameters types are extract from the ``__init`` method
+parameters. The kernel function arguments list is derived from the
----------------



================
Comment at: clang/test/SemaSYCL/special-class-attribute-on-non-sycl.cpp:11
+class __attribute__((sycl_special_class)) special_class {
+  void __init(){};
+};
----------------



================
Comment at: clang/test/SemaSYCL/special-class-attribute.cpp:5
+class [[clang::sycl_special_class]] class1 {
+  void __init(){};
+};
----------------
Can you correct this entire file not to have the trailing semicolons?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114483/new/

https://reviews.llvm.org/D114483