[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

[Son Tuan Vu via Phabricator via cfe-commits]

tyb0807 marked an inline comment as done.
tyb0807 added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-mops.c:3
+
+// RUN: %clang_cc1 -triple aarch64-arm-unknown-eabi -target-feature +mops -S -emit-llvm -o - %s  | FileCheck %s
+
----------------
SjoerdMeijer wrote:
> I forgot if we add negative tests for these things, i.e. check if we error if we don't have `+mops` or `__ARM_FEATURE_MOPS` set? I guess so?
Currently this only tests if the support for memset tagged intrinsic is in clang, how to enable the memset tagged intrinsic is implemented (and tested) in a separate patch (https://reviews.llvm.org/D116160). Note how we set `__ARM_FEATURE_MOPS` manually in line 5.

This test will thus be updated with negative tests in https://reviews.llvm.org/D116160


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117753/new/

https://reviews.llvm.org/D117753