[PATCH] D118120: [C++20] [Modules] Only check decls under namespace scope in CheckRedeclarationExported

[Nathan Sidwell via Phabricator via cfe-commits]

urnathan accepted this revision.
urnathan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:1643-1648
+  if (!New->getLexicalDeclContext()
+           ->getNonTransparentContext()
+           ->isFileContext() ||
+      !Old->getLexicalDeclContext()
+           ->getNonTransparentContext()
+           ->isFileContext())
----------------
ChuanqiXu wrote:
> This is formatted by clang-format, the original may be too long:
> ```
> if (!New->getLexicalDeclContext()->getNonTransparentContext()->isFileContext() ||
>     ...
> ```
I like continuation lines where the operator is on the start of the new line rather than the end of the old one :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118120/new/

https://reviews.llvm.org/D118120