[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm!



================
Comment at: clang-tools-extra/clang-tidy/NoLintDirectiveHandler.cpp:187
+static SmallVector<NoLintBlockToken>
+formNoLintBlocks(SmallVector<NoLintToken> &NoLints,
+                 SmallVectorImpl<NoLintToken> &UnmatchedTokens) {
----------------
let's drop the `&` here to make sure caller does an explicit `std::move`. since the helper is actually consuming the tokens inside the vector and in theory it shouldn't be used afterwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116085/new/

https://reviews.llvm.org/D116085