[PATCH] D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 24 16:53:51 PST 2022


benlangmuir added a comment.

> Does check-orc-rt need to be added to COMPILER_RT_TEST_SUITES too? I guess not, otherwise we wouldn't have seen this missing dependency in the first place?

It doesn't affect `check-compiler-rt`, because `check-compiler-rt` actually wraps the `check-all` target from compiler-rt rather than depending on the individual components defined in this file.  I think we only need to add individual components here if it's useful to someone.

There's actually a whole bunch of `check-` targets in compiler-rt that are not reflected here, so I'd prefer to call it a separate issue if we do add more:

  check-asan-${platform}-${arch}
  check-builtins
  check-crt
  check-fuzzer-${platform}-${arch}
  check-fuzzer-${stdlib_name}-${arch}
  check-fuzzer-unit
  check-hwasan-lam
  check-interception
  check-memprof
  check-memprof-dynamic
  check-orc-rt
  check-scudo
  check-scudo_standalone
  check-shadowcallstack
  check-tsan-${platform}-${arch}
  check-tsan-dynamic
  check-ubsan-${test_mode}-${platform}-${arch}
  check-xray


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118087/new/

https://reviews.llvm.org/D118087



More information about the cfe-commits mailing list