[PATCH] D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 24 16:09:50 PST 2022


benlangmuir created this revision.
benlangmuir added reviewers: lhames, fhahn.
Herald added a subscriber: mgorny.
benlangmuir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Add missing dependency on llvm-jitlink when building compiler-rt with LLVM_BUILD_EXTERNAL_COMPILER_RT. Previously we would non-deterministically fail the tests due to the missing binary.

rdar://87247681


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118087

Files:
  clang/runtime/CMakeLists.txt


Index: clang/runtime/CMakeLists.txt
===================================================================
--- clang/runtime/CMakeLists.txt
+++ clang/runtime/CMakeLists.txt
@@ -130,7 +130,7 @@
   if(LLVM_INCLUDE_TESTS)
     # Add binaries that compiler-rt tests depend on.
     set(COMPILER_RT_TEST_DEPENDENCIES
-      FileCheck count not llvm-nm llvm-objdump llvm-symbolizer)
+      FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink)
 
     # Add top-level targets for various compiler-rt test suites.
     set(COMPILER_RT_TEST_SUITES check-fuzzer check-asan check-hwasan check-asan-dynamic check-dfsan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118087.402710.patch
Type: text/x-patch
Size: 621 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220125/f5ff2866/attachment.bin>


More information about the cfe-commits mailing list