[PATCH] D117137: [Driver] Add CUDA support for --offload param
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 24 13:41:15 PST 2022
tra added inline comments.
================
Comment at: clang/lib/Driver/Driver.cpp:153-155
+ if (TT->getArch() == llvm::Triple::spirv64 &&
+ TT->getVendor() == llvm::Triple::UnknownVendor &&
+ TT->getOS() == llvm::Triple::UnknownOS)
----------------
What's expected to happen if someone specifies `spirv64-nvidia` ?
If someone uses `spirv64-foo-bar` I think it would match this condition.
Accepting `spirv64-foo-bar`, but not `spirv64-nvidia-unknown` would be somewhat odd. I think we either should check a fully-specified triple, or only check the parts that matter -- `getArch()` in this case, or, maybe, arch and vendor.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117137/new/
https://reviews.llvm.org/D117137
More information about the cfe-commits
mailing list