[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

[David Goldman via Phabricator via cfe-commits]

dgoldman added a comment.

In D117830#3267404 <https://reviews.llvm.org/D117830#3267404>, @cishida wrote:

> My understanding for the header map restriction is because headermaps are generally emitted once for a framework build and only consumed to build such framework and this struct information is only queried during this.
> It sounds like for the clangd support, you're not as interested in what framework is being built, but the name of the framework when included via framework style in any context. Is that correct? It seems fine to extend its use cases. @jansvoboda11 What do you think?

Yep, exactly, for clangd, we want to know when a header is included via a framework style include (although maybe it would be better to know if a header is actually apart of a framework regardless of the spelling to import it?) so we can generate a proper framework style include for symbols in the framework. That lets us suggest an include of <UIKit/UIKit.h> for UIView, for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117830/new/

https://reviews.llvm.org/D117830