[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

[Zahira Ammarguellat via Phabricator via cfe-commits]

zahiraam marked 11 inline comments as done.
zahiraam added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:16686-16687
+    if (RD->hasAttr<SYCLSpecialClassAttr>()) {
+      auto *Def = RD->getDefinition();
+      if (Def && !Def->hasInitMethod())
+        Diag(RD->getLocation(),
----------------
aaron.ballman wrote:
> I think we can assert there is a definition given that this is called from "ActOnTagFinishDefinition".
@aaron.ballman Not sure what you mean by "that this is called from".  We are inside the ActOnTagFinishDefinition function. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114483/new/

https://reviews.llvm.org/D114483