[PATCH] D117994: [Clang] Implement multidimentional subscript operator
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 24 11:29:49 PST 2022
erichkeane added a comment.
I don't have sufficient experience to approve this, but I DID look through it and found 1 suspicious thing.
================
Comment at: clang/lib/Sema/SemaAccess.cpp:1799
+ R = SourceRange(ArgExprs.front()->getBeginLoc(),
+ ArgExprs.front()->getEndLoc());
+ }
----------------
So should the 'end' be `ArgExprs.back()->getEndLoc()`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117994/new/
https://reviews.llvm.org/D117994
More information about the cfe-commits
mailing list