[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

Qiu Chaofan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 24 02:31:28 PST 2022


qiucf added a comment.

In D117181#3262288 <https://reviews.llvm.org/D117181#3262288>, @jsji wrote:

>> Won't that end up producing a warning on ALL code built on any Linux distro with a GCC toolchain older than 12.1? That would be terrible.
>
> Good point. Yes, so should be something like:
>
>   IsDistroWithNewToolchain = ( Distro.IsRedhat() && Distro >= Distro::RHEL9  ||  (Distro.IsUbuntu() && Distro >= Distro::xxx)
>   bool IEEELongDouble = T.isOSLinux() && IsDistroWithNewToolchain;

Thanks for reminding about checking Linux distro version! Besides, would it be acceptable that we add a variable to cmake to determine default long double semantics (like current GCC)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117181/new/

https://reviews.llvm.org/D117181



More information about the cfe-commits mailing list