[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 23 08:23:36 PST 2022


benshi001 marked an inline comment as done.
benshi001 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.h:22
 class LLVM_LIBRARY_VISIBILITY AVRToolChain : public Generic_ELF {
+  std::string AVRMcu;
+
----------------
aykevl wrote:
> I think I would have called this `CPU` not `AVRMcu`, but `AVRMcu` is fine.
It is changed to FamilyName, since family is checked other than the device name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117423/new/

https://reviews.llvm.org/D117423



More information about the cfe-commits mailing list