[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 23 07:09:13 PST 2022


LegalizeAdulthood added a comment.

In D7982#3264009 <https://reviews.llvm.org/D7982#3264009>, @carlosgalvezp wrote:

> In D7982#3263920 <https://reviews.llvm.org/D7982#3263920>, @LegalizeAdulthood wrote:
>
>> In D7982#3263790 <https://reviews.llvm.org/D7982#3263790>, @carlosgalvezp wrote:
>>
>>> Great patch, thanks!!
>>
>> Can you mark the patch as accepted in phabricator?
>> Thanks
>
> I did do that and it shows that I have accepted the revision, what else should I do?
>
> Or is it because of the negative vote from @alexfh ? Since he's not replying perhaps you can remove him from the reviewer list?

Ah yes, I see now, it's in the history that you accepted the patch.
I'm not sure how to clear the "needs revision" status from Alex
years ago, so I'm going to submit this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D7982/new/

https://reviews.llvm.org/D7982



More information about the cfe-commits mailing list