[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

[Salman Javed via Phabricator via cfe-commits]

salman-javed-nz marked 12 inline comments as done.
salman-javed-nz added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/NoLintPragmaHandler.cpp:63
+// as parsed from the file's character contents.
+class NoLintToken {
+public:
----------------
kadircet wrote:
> kadircet wrote:
> > why not just a basic struct ? i don't think all of these accessors/constructors carry their weight (as mentioned below once the `ChecksGlob` is not lazily computed, there should be no need for any of these).
> can we please inline the definitions (if there's a good reason to stick with the class)?
I've removed as many accessors and constructors as I can from this class. I believe there's still some value in hiding the `Optional<std::string> Checks` and `CachedGlobList ChecksGlob` behind methods, because if you modify one, you must modify the other for the `NoLintToken` object to make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116085/new/

https://reviews.llvm.org/D116085