[PATCH] D117939: [clang-tidy] Add more documentation about check development

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 22 14:22:09 PST 2022


LegalizeAdulthood added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:295
+Reference <https://clang.llvm.org/docs/LibASTMatchersReference.html>`_ to understand
+the relationship between the different matcher funtions.
+
----------------
Should be `functions`


================
Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:338
+matching expressions to simplify your matcher.  Just like breaking up a huge function
+into smaller chunks with an intention revealing name can help you understand a complex
+algorithm, breaking up a matcher into smaller matchers with intention revealing names
----------------
chunks plural, "an intention revealing name" singular mismatch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117939/new/

https://reviews.llvm.org/D117939



More information about the cfe-commits mailing list