[PATCH] D114095: [clang][lex] Include tracking: simplify and move to preprocessor

Fri Jan 21 19:42:24 PST 2022

vsapsai added a comment.

In D114095#3261073 <https://reviews.llvm.org/D114095#3261073>, @jansvoboda11 wrote:

> @vsapsai do you have any further concerns? My only intended change at this point is Duncan's suggestion.

My understanding was that we were going with ID vectors approach and not with bitvectors, and the current code still uses bitvectors. Also I have a minor readability concern about `auto` usage, it seems to be used more often than  the coding standard <https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable> asks for. But that usage is in serialization/deserialization code which I wasn't sure if it was going to stay.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114095/new/

https://reviews.llvm.org/D114095