[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 21 11:20:20 PST 2022

sammccall resigned from this revision.
sammccall added subscribers: jansvoboda11, cishida.
sammccall added a comment.

Thanks for splitting this out from the other patch. This feels subtle and I don't think I know enough about frameworks to review.

@cishida made a recent change here which @jansvoboda11 reviewed - I'm guessing they'd know what to do here.

Comment at: clang/lib/Lex/HeaderSearch.cpp:1043
     // If this file is found in a header map and uses the framework style of
     // includes, then this header is part of a framework we're building.
The comment here explicitly say "in a header map and". Unfortunately it doesn't say why, and I don't know enough to guess.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list