[PATCH] D116966: [analyzer] Don't specify PLUGIN_TOOL for analyzer plugins

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 21 07:10:35 PST 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D116966#3261202 <https://reviews.llvm.org/D116966#3261202>, @ArcsinX wrote:

> In D116966#3261168 <https://reviews.llvm.org/D116966#3261168>, @aaron.ballman wrote:
>
>> However, the changes you've made don't look to be specific to building on Windows; this removes `PLUGIN_TOOL` for all targets. I presume it's still needed for non-Windows targets, isn't it?
>
> As I can see, `PLUGIN_TOOL` is unused for non-Windows OS (at least for now): https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/AddLLVM.cmake#L648

Yeah, that seems to be the case. LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116966/new/

https://reviews.llvm.org/D116966



More information about the cfe-commits mailing list