[PATCH] D117836: Fix obvious typo

Gabriel Ferreira Teles Gomes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 21 05:40:25 PST 2022

gftg created this revision.
gftg added a comment.
gftg updated this revision to Diff 401949.
gftg updated this revision to Diff 401963.
gftg edited the summary of this revision.
gftg published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

/me wondering how to convert this draft submission into a regular one.

gftg added a comment.

Testing that using arc diff --edit --verbatim converts from draft to
regular diff.

gftg added a comment.

Update the commit message with something meaningful for the git history.

The -fcf-protection option takes an optional argument, which allows the
requesting of control-flow protection on returns, or on indirect jumps
and calls, or both. One of the comments in the code applies to returns,
yet it mentions branches (for indirect calls and jumps). This patch
fixes this obvious typo.

  rG LLVM Github Monorepo



Index: clang/include/clang/Basic/TargetInfo.h
--- clang/include/clang/Basic/TargetInfo.h
+++ clang/include/clang/Basic/TargetInfo.h
@@ -1507,7 +1507,7 @@
   virtual bool
   checkCFProtectionBranchSupported(DiagnosticsEngine &Diags) const;
-  /// Check if the target supports CFProtection branch.
+  /// Check if the target supports CFProtection return.
   virtual bool
   checkCFProtectionReturnSupported(DiagnosticsEngine &Diags) const;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117836.401963.patch
Type: text/x-patch
Size: 510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220121/0bce2954/attachment.bin>

More information about the cfe-commits mailing list