[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

Fri Jan 21 04:45:38 PST 2022

ksyx added a comment.

In D117520#3260443 <https://reviews.llvm.org/D117520#3260443>, @curdeius wrote:

> In D117520#3258454 <https://reviews.llvm.org/D117520#3258454>, @MyDeveloperDay wrote:
>
>> I think its been fixed, in the last but one diff.
>>
>> Generally speaking we simply cannot have --output-replacements-xml , -n or --dry-run show replacements that amount to nothing because this is the mechanism by which 100s of repos fail commits thinking their is a clang-format issue.
>>
>> Last revision I tried these issues seem to have disappeared
>
> I understood that it was fixed but I'd really like to have a test case that reproduces it.
> We might have the same problem somewhere else, no?
> Can we have a part of `verifyFormat` that runs with `DryRun=true` and checks the replacements?

Yes I see your point so I added one in the last diff.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117520/new/

https://reviews.llvm.org/D117520