[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

Ties Stuij via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 21 04:09:15 PST 2022


stuij marked 2 inline comments as done.
stuij added a comment.

> Thanks for the update. Same(ish) questions for the Arm side. Otherwise this LGTM

Ai, thanks. Should have checked Arm as well.

> Oh, also is there an ID for this CPU that is worth adding to getHostCPUNameForARM in Host.cpp?

Yup, thanks. Added.



================
Comment at: llvm/lib/Target/ARM/ARM.td:1446
 
+def : ProcNoItin<"cortex-x1c",                          [ARMv82a,
+                                                         FeatureHWDivThumb,
----------------
dmgreen wrote:
> Should this have ProcX1C added?
yes :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117202/new/

https://reviews.llvm.org/D117202



More information about the cfe-commits mailing list