[clang-tools-extra] 825a3cd - [clangd] Fail inlayHints requests on content changes

Kadir Cetinkaya via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 21 03:41:17 PST 2022


Author: Kadir Cetinkaya
Date: 2022-01-21T12:40:49+01:00
New Revision: 825a3cd6b6972b6a50b80bed7d951d7ea7f90669

URL: https://github.com/llvm/llvm-project/commit/825a3cd6b6972b6a50b80bed7d951d7ea7f90669
DIFF: https://github.com/llvm/llvm-project/commit/825a3cd6b6972b6a50b80bed7d951d7ea7f90669.diff

LOG: [clangd] Fail inlayHints requests on content changes

This should improve the overall UX by making the labels less jumpy.

Differential Revision: https://reviews.llvm.org/D117776

Added: 
    

Modified: 
    clang-tools-extra/clangd/ClangdServer.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/ClangdServer.cpp b/clang-tools-extra/clangd/ClangdServer.cpp
index 0760ed5317be..a7210e0526a4 100644
--- a/clang-tools-extra/clangd/ClangdServer.cpp
+++ b/clang-tools-extra/clangd/ClangdServer.cpp
@@ -775,7 +775,7 @@ void ClangdServer::inlayHints(PathRef File, llvm::Optional<Range> RestrictRange,
       return CB(InpAST.takeError());
     CB(clangd::inlayHints(InpAST->AST, std::move(RestrictRange)));
   };
-  WorkScheduler->runWithAST("InlayHints", File, std::move(Action));
+  WorkScheduler->runWithAST("InlayHints", File, std::move(Action), Transient);
 }
 
 void ClangdServer::onFileEvent(const DidChangeWatchedFilesParams &Params) {


        


More information about the cfe-commits mailing list