[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 20 17:14:45 PST 2022


pengfei added inline comments.


================
Comment at: clang/lib/Headers/avx512fintrin.h:31
+ * appear in the interface though. */
+typedef signed char __v64qs __attribute__((__vector_size__(64)));
+
----------------
craig.topper wrote:
> pengfei wrote:
> > Do we need to declare explicit `signed`?
> The signedness of char is platform specific.
Got it, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117791/new/

https://reviews.llvm.org/D117791



More information about the cfe-commits mailing list