[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 marked an inline comment as done.
jhuber6 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5830
+  // host, makes the system more robust, and improves performance.
+  if (IsOpenMPDevice) {
+    CmdArgs.push_back("-fvisibility");
----------------
JonChesterfield wrote:
> I think we need some more code here to detect if the user has already specified a value for fvisibility so that we don't clobber it
I put the code there with the intent of putting the else there, but forgot to actually put it there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117806/new/

https://reviews.llvm.org/D117806