[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 20 15:56:31 PST 2022


JonChesterfield added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5830
+  // host, makes the system more robust, and improves performance.
+  if (IsOpenMPDevice) {
+    CmdArgs.push_back("-fvisibility");
----------------
I think we need some more code here to detect if the user has already specified a value for fvisibility so that we don't clobber it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117806/new/

https://reviews.llvm.org/D117806



More information about the cfe-commits mailing list